Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ui-babel-preset): ensure runtime helper is used for _objectSpread
because of babel/babel#10261 if you don't speficiy a version of @babel/helpers to use, it will default to 7.0.0-beta.0 which doesn't have _objectSpread TEST PLAN: * Before checking this out, * run babel to transpile a file that uses object spread syntax, like `const foo = {...bar}` * you should see inline _objectSpread helpers like what is currently on npm. see for example: https://unpkg.com/browse/@instructure/ui-a11y@6.10.0/es/Dialog/index.js (See how that has a _objectSpread inlined in it?) * with this checked out, * run yarn build * Look at: packages/ui-a11y/es/Dialog/index.js * it should not have an inline _objectSpread function, but should Instead have a line like import _objectSpread2 from "@babel/runtime/helpers/esm/objectSpread2" Change-Id: I1a65ae85789848ad0702e43aafdc5580210942eb Reviewed-on: https://gerrit.instructure.com/208612 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Daniel Sasaki <dsasaki@instructure.com> QA-Review: Steve Jensen <sejensen@instructure.com> Product-Review: Steve Jensen <sejensen@instructure.com> Visual-Regression-Test: Steve Jensen <sejensen@instructure.com>
- Loading branch information