chore: add regression tests for server-side-rendering #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Preview URL: https://1174--preview-instui.netlify.app |
Brailor
reviewed
Mar 24, 2023
NamNg1121
force-pushed
the
INSTUI-3743-add-next-js-support-to-the-regression-testing-suite
branch
from
c52de80
to
c351f84
Compare
Brailor
reviewed
Mar 30, 2023
regression-test/package.json
Outdated
| @@ -6,6 +6,8 @@ | |||
| "scripts": { | |||
| "build:webpack4": "webpack", | |||
| "build:esbuild": "node esbuild.cjs", | |||
| "build:next": "next build ./src", | |||
| "start:next": "next start ./src ", | |||
There was a problem hiding this comment.
This has to be changed to next dev ./src, since we wan't to test the development build of the next.js app.
Comment on lines
+102
to
+130
| server-side-rendering-regression-test: | ||
| needs: release | ||
| if: "!startsWith(github.event.head_commit.message, 'chore(release)')" | ||
| name: Regression testing | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| browser: [chrome, firefox] | ||
| defaults: | ||
| run: | ||
| working-directory: ./regression-test | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16' | ||
| cache: 'yarn' | ||
| - name: Retrieve latest snapshot version | ||
| run: node prepare.js | ||
| - name: Install dependencies for regression testing | ||
| run: yarn install --no-immutable | ||
| - name: Build project and start the server | ||
| run: | | ||
| yarn build:next | ||
| yarn start:next & | ||
| - name: Run regression tests | ||
| run: npx testcafe ${{ matrix.browser }}:headless ./src/test.ts |
There was a problem hiding this comment.
Since the next.js app throws multiple errors, I would turn off this job until those errors are resolved in the regression-test application, because of those errors the whole workflow will always fail.
You can turn off a job by adding an if statement to the job itself:
server-side-rendering-regression-test:
needs: release
if: false # "!startsWith(github.event.head_commit.message, 'chore(release)')"
name: Regression testing
...
matyasf
changed the title
matyasf
force-pushed
the
INSTUI-3743-add-next-js-support-to-the-regression-testing-suite
branch
from
c351f84
to
d86d7b3
Compare
joyenjoyer
force-pushed
the
INSTUI-3743-add-next-js-support-to-the-regression-testing-suite
branch
from
d86d7b3
to
28eb65b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.