chore: update testing-library, husky and lerna major versions #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1519--preview-instui.netlify.app |
matyasf
requested changes
May 24, 2024
yeah, it's tricky because if I fix it and commit it, our linter changes it back which throws the lint error... I'll find another way I guess |
matyasf
reviewed
May 27, 2024
Comment on lines
+29
to
+46
| "@testing-library/jest-dom": "^6.4.5", | ||
| "@testing-library/react": "^15.0.7" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/runtime": "^7.23.2", | ||
| "@codemirror/autocomplete": "^6.10.2", | ||
| "@codemirror/commands": "^6.3.0", | ||
| "@babel/runtime": "^7.24.5", | ||
| "@codemirror/autocomplete": "^6.16.0", | ||
| "@codemirror/commands": "^6.5.0", | ||
| "@codemirror/lang-css": "^6.2.1", | ||
| "@codemirror/lang-html": "^6.4.6", | ||
| "@codemirror/lang-javascript": "^6.2.1", | ||
| "@codemirror/lang-html": "^6.4.9", | ||
| "@codemirror/lang-javascript": "^6.2.2", | ||
| "@codemirror/lang-json": "^6.0.1", | ||
| "@codemirror/lang-markdown": "^6.2.2", | ||
| "@codemirror/language": "^6.9.1", | ||
| "@codemirror/legacy-modes": "^6.3.3", | ||
| "@codemirror/lint": "^6.4.2", | ||
| "@codemirror/search": "^6.5.4", | ||
| "@codemirror/state": "^6.3.0", | ||
| "@codemirror/view": "^6.21.3", | ||
| "@codemirror/lang-markdown": "^6.2.5", | ||
| "@codemirror/language": "^6.10.1", | ||
| "@codemirror/legacy-modes": "^6.4.0", | ||
| "@codemirror/lint": "^6.7.1", | ||
| "@codemirror/search": "^6.5.6", | ||
| "@codemirror/state": "^6.4.1", | ||
| "@codemirror/view": "^6.26.3", |
There was a problem hiding this comment.
This went trough without bugs this time?
There was a problem hiding this comment.
yes and I didn't need to pin any packages this time. I'm not sure why it was failing previous times
matyasf
approved these changes
May 27, 2024
HerrTopi
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-3847
INSTUI-3936