fix(ui-tabs): fix horizontal scrolling with keyboard navigation #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1521--preview-instui.netlify.app |
joyenjoyer
approved these changes
May 17, 2024
matyasf
requested changes
May 29, 2024
|
|
||
| this.state.withTabListOverflow && | ||
| this.showActiveTabIfOverlayed(this._tabList!.querySelector(`#tab-${id}`)) | ||
| setTimeout(() => { |
There was a problem hiding this comment.
This is very ugly :(
If you put in such code please leave a detailed comment why this hack was necessary
|
Can you please add the JIRA ticket reference? Thanks! |
HerrTopi
force-pushed
the
tabs-keyboard-bug
branch
from
6367489
to
e1125d3
Compare
joyenjoyer
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4019