Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom role names for permission argument #988

Closed
emtunc opened this issue Nov 27, 2021 · 3 comments · Fixed by #1038
Closed

Allow custom role names for permission argument #988

emtunc opened this issue Nov 27, 2021 · 3 comments · Fixed by #1038
Labels

Comments

@emtunc
Copy link

emtunc commented Nov 27, 2021

As per https://docs.github.com/en/rest/reference/teams#add-or-update-team-repository-permissions - custom role names (https://docs.github.com/en/enterprise-cloud@latest/organizations/managing-peoples-access-to-your-organization-with-roles/managing-custom-repository-roles-for-an-organization) are now permitted when adding/updating permissions for teams.

The Terraform provider still only expects pull, triage, push, maintain, or admin

For the avoidance of doubt, I have tested setting permissions with a custom role name (it seems to be case sensitive) via the GH API and it works.

Would someone be so kind as to allow string values for the permission argument please?

@joshua-hancox
Copy link
Contributor

I raised a PR here, based on another - could anyone help in getting this reviewed/merged? 😃

#1113

@joshua-hancox
Copy link
Contributor

@kfcampbell could we merge/release this?

@ghost
Copy link

ghost commented May 27, 2022

Both of the linked PRs are ready to go :shipit: (sorry about the delay in updating mine @joshuahancox)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants