Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding security_and_analysis block to github_repository resource. closes#1104 #1304

Merged
merged 4 commits into from Nov 16, 2022
Merged

[Feature] Adding security_and_analysis block to github_repository resource. closes#1104 #1304

merged 4 commits into from Nov 16, 2022

Conversation

kuhlman-labs
Copy link
Contributor

Adding block for the security_and_analysis field in github_repository resource to configure advanced security settings for a repo.

The Go GitHub client library does not currently support the secret_scanning_push_protection field in its current release but a PR has been merged and will be available on the next release. The necessary code to implement this field has been commented out and can be uncommented once a new release is available.

Closes:
#1104

@kfcampbell
Copy link
Member

🎉 I'm looking forward to that release!

@adrawbond-alto
Copy link

Any idea which release this will be included in? We have forked the provider repo and merged in this PR and are building the provider ourselves so we can get this functionality now. We'd really prefer not having to maintain our fork however. Thanks @kuhlman-labs for putting this together.

@kfcampbell
Copy link
Member

It looks like that feature was added here and released in v48!

@kuhlman-labs I've created this PR to bump to v48 and I'll merge it shortly. After that, this will be unblocked!

@kuhlman-labs
Copy link
Contributor Author

@kfcampbell I have updated this PR to include the secret_scanning_push_protection field, should be good to merge. 🚀

@kfcampbell
Copy link
Member

@kuhlman-labs when attempting to run the new integration tests, I'm getting an error: security_and_analysis.0.secret_scanning_push_protection": required field is not set. It looks like maybe that's a valid error and that setting is missing from the test HCL. Can you reproduce?

@nickfloyd nickfloyd added Type: Feature New feature or request Priority: High labels Oct 31, 2022
@kuhlman-labs
Copy link
Contributor Author

@kfcampbell I was able to repro and I pushed changes that should fix 👍🏻

@nickfloyd
Copy link
Contributor

@kfcampbell I was able to repro and I pushed changes that should fix 👍🏻

Validated that all the new tests run 🟢 - this should be g2g!

@nickfloyd nickfloyd merged commit e827c6f into integrations:main Nov 16, 2022
@sethvargo
Copy link
Contributor

Hey folks - sorry to be the bearer of bad news, but this breaks things: #1419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants