Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go-github v50 #1516

Merged
merged 1 commit into from Jan 30, 2023
Merged

Update to go-github v50 #1516

merged 1 commit into from Jan 30, 2023

Conversation

ilmax
Copy link
Contributor

@ilmax ilmax commented Jan 29, 2023

Bump go-github to v50.

I run some tests locally via make testacc and beside some 401 because I'm using a fine-grained PAT everything seems ok.

I'm using a fine-grained PAT because I'm the owner of an enterprise and organization in GitHub and I can't limit the scope of the old style PAT to only the test organization I created. Any suggestion here is appreciated.

Beside updating the module, I had to change 2 lines of code due to this breaking change google/go-github#2646

/cc @kfcampbell


Behavior

Before the change?

After the change?

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@kfcampbell kfcampbell merged commit 30cc485 into integrations:main Jan 30, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants