Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add allow_forking to github_repository #1649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pascal-hofmann
Copy link
Contributor

@pascal-hofmann pascal-hofmann commented Apr 13, 2023

Resolves #1071


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change -> No permissions to add labels. :(

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Pull request type

  • Feature/model/API additions: Type: Feature

@kfcampbell
Copy link
Member

Thank you @pascal-hofmann! Do you mind helping me run these tests? They're passing for me on the main branch but failing on this branch with a Error: PATCH https://api.github.com/repos/kfcampbell-terraform-provider/tf-acc-test-pub-vuln-3xaws: 422 This organization does not allow private repository forking [] error. That's weird to me, since my repository has private forking enabled everywhere:

image

Does it pass for you?

@pascal-hofmann
Copy link
Contributor Author

@kfcampbell No, it does not. :(

No idea what's wrong here…

@sergiuciudin
Copy link

Any chance of getting this merged?

@yaroslav-nakonechnikov
Copy link

is it forgotten?

@pascal-hofmann
Copy link
Contributor Author

I've just rebased this PR and resolved the conflicts.

@glerchundi
Copy link

glerchundi commented Apr 8, 2024

Is there anything it can be done to push this forward? In highly automated environments as ours, and trying to push innersourcing internally, this is a bump on the road. Let us know if there's something we can do to help you on this.

Thanks! 🙏

@harpunius
Copy link

Hey, what is blocking this PR? We'd love to have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] less Allow forking avariable for private repository.
6 participants