Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: incorrect field name in docs for github_repository_collaborators #1779

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Jeffreyhung
Copy link
Contributor

The doc for the repository_collaborators was having:

The team block supports:
team - (Required) The GitHub team id or the GitHub team slug

But the actual field name used in terraform is team_id, not team.

Updated the docs to prevent confusion.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jeffreyhung, good catch!

@kfcampbell kfcampbell merged commit a90a2b2 into integrations:main Jul 7, 2023
4 checks passed
doonga pushed a commit to doonga/greyrock-ops that referenced this pull request Jul 12, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github](https://registry.terraform.io/providers/integrations/github)
([source](https://togithub.com/integrations/terraform-provider-github))
| required_provider | minor | `5.29.0` -> `5.30.1` |

---

### Release Notes

<details>
<summary>integrations/terraform-provider-github (github)</summary>

###
[`v5.30.1`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.30.1)

[Compare
Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.29.0...v5.30.1)

#### What's Changed

- Fix: incorrect field name in docs for github_repository_collaborators
by [@&#8203;Jeffreyhung](https://togithub.com/Jeffreyhung) in
[integrations/terraform-provider-github#1779
- fix: remove validation for team.permission on
`github_repository_collaborators` by
[@&#8203;jsifuentes](https://togithub.com/jsifuentes) in
[integrations/terraform-provider-github#1781
- build(deps): bump golang.org/x/crypto from 0.10.0 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[integrations/terraform-provider-github#1784
- Don't run go mod tidy on release by
[@&#8203;kfcampbell](https://togithub.com/kfcampbell) in
[integrations/terraform-provider-github#1788

#### New Contributors

- [@&#8203;Jeffreyhung](https://togithub.com/Jeffreyhung) made their
first contribution in
[integrations/terraform-provider-github#1779
- [@&#8203;jsifuentes](https://togithub.com/jsifuentes) made their first
contribution in
[integrations/terraform-provider-github#1781

**Full Changelog**:
integrations/terraform-provider-github@v5.30.0...v5.30.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi43LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
felixlut pushed a commit to felixlut/terraform-provider-github that referenced this pull request Jul 22, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants