fix: remove validation for team.permission on github_repository_collaborators
#1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
approved these changes
Jul 10, 2023
doonga
pushed a commit
to doonga/greyrock-ops
that referenced
this pull request
Jul 12, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | minor | `5.29.0` -> `5.30.1` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v5.30.1`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.30.1) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.29.0...v5.30.1) #### What's Changed - Fix: incorrect field name in docs for github_repository_collaborators by [@​Jeffreyhung](https://togithub.com/Jeffreyhung) in [integrations/terraform-provider-github#1779 - fix: remove validation for team.permission on `github_repository_collaborators` by [@​jsifuentes](https://togithub.com/jsifuentes) in [integrations/terraform-provider-github#1781 - build(deps): bump golang.org/x/crypto from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [integrations/terraform-provider-github#1784 - Don't run go mod tidy on release by [@​kfcampbell](https://togithub.com/kfcampbell) in [integrations/terraform-provider-github#1788 #### New Contributors - [@​Jeffreyhung](https://togithub.com/Jeffreyhung) made their first contribution in [integrations/terraform-provider-github#1779 - [@​jsifuentes](https://togithub.com/jsifuentes) made their first contribution in [integrations/terraform-provider-github#1781 **Full Changelog**: integrations/terraform-provider-github@v5.30.0...v5.30.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi43LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
felixlut
pushed a commit
to felixlut/terraform-provider-github
that referenced
this pull request
Jul 22, 2023
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1775
Behavior
Before the change?
github_repository_collaborators.team.#.permissionhad validation that prevented the use of custom rolesAfter the change?
github_repository_collaborators.team.#.permissionno longer has a validation rule, matching the same configuration as thegithub_repository_collaborators.user.#.permissionattribute.Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Type: Bug