Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to downgrade membership when github_membership is destroyed #1783

Merged
merged 10 commits into from
Jul 14, 2023
Merged

feat: add ability to downgrade membership when github_membership is destroyed #1783

merged 10 commits into from
Jul 14, 2023

Conversation

jsifuentes
Copy link
Contributor

@jsifuentes jsifuentes commented Jul 9, 2023 •
edited

Resolves #1782

Behavior

Before the change?

  • github_membership allows for a "create or update" resource creation, so if the membership exists before the resource is managed by Terraform then Terraform will just update the membership. When the resource is destroyed, membership from the org is always revoked.

After the change?

  • You can now add downgrade_on_destroy = true to a github_membership resource. Instead of revoking org membership, the membership role will be set to 'member' when the resource is destroyed.

Additional info

  • I added a new test case specifically to test this downgrade scenario. The function testAccGithubMembershipConfigDowngradable sets the role to admin and sets the downgrade_on_destroy to true. Since the Destroy no longer completely removes the membership during this test case, the membership is cleaned up during the CheckDestroy.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

  • Feature/model/API additions: Type: Feature

@jsifuentes jsifuentes marked this pull request as ready for review July 9, 2023 23:11
@kfcampbell kfcampbell merged commit fabff68 into integrations:main Jul 14, 2023
3 checks passed
doonga pushed a commit to doonga/greyrock-ops that referenced this pull request Jul 15, 2023
@greyrock-repo-duster
feat(terraform-provider): update terraform github to 5.31.0 (#929)
c629f97 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github](https://registry.terraform.io/providers/integrations/github)
([source](https://togithub.com/integrations/terraform-provider-github))
| required_provider | minor | `5.30.1` -> `5.31.0` |

---

### Release Notes

<details>
<summary>integrations/terraform-provider-github (github)</summary>

###
[`v5.31.0`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.31.0)

[Compare
Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.30.1...v5.31.0)

#### What's Changed

- build(deps): bump golang.org/x/oauth2 from 0.9.0 to 0.10.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[integrations/terraform-provider-github#1785
- 💅 Typo in docs by [@&#8203;nmacri](https://togithub.com/nmacri) in
[integrations/terraform-provider-github#1789
- Attempted fix for
[#&#8203;1657](https://togithub.com/integrations/terraform-provider-github/issues/1657)
by [@&#8203;yaakov-h](https://togithub.com/yaakov-h) in
[integrations/terraform-provider-github#1774
- Do not change allow_update_branch/has_downloads on archived repos by
[@&#8203;kristian-lesko](https://togithub.com/kristian-lesko) in
[integrations/terraform-provider-github#1795
- feat: add ability to downgrade membership when `github_membership` is
destroyed by [@&#8203;jsifuentes](https://togithub.com/jsifuentes) in
[integrations/terraform-provider-github#1783

#### New Contributors

- [@&#8203;nmacri](https://togithub.com/nmacri) made their first
contribution in
[integrations/terraform-provider-github#1789
- [@&#8203;yaakov-h](https://togithub.com/yaakov-h) made their first
contribution in
[integrations/terraform-provider-github#1774

**Full Changelog**:
integrations/terraform-provider-github@v5.30.1...v5.31.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjUiLCJ1cGRhdGVkSW5WZXIiOiIzNi44LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: greyrock-bot <112729691+greyrock-bot[bot]@users.noreply.github.com>
jsifuentes added a commit to jsifuentes/terraform-provider-github that referenced this pull request Jul 17, 2023
@jsifuentes @kfcampbell
feat: add ability to downgrade membership when github_membership is…
1b6f893 
… destroyed (integrations#1783)

* feat: add ability to downgrade membership on destroy

* add docs

* formatting

* formatting

* check membership status before downgrading

* fix lint

* fix lint

* Update github/resource_github_membership.go

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
felixlut pushed a commit to felixlut/terraform-provider-github that referenced this pull request Jul 22, 2023
@jsifuentes @kfcampbell @felixlut
feat: add ability to downgrade membership when github_membership is…
8b44821 
… destroyed (integrations#1783)

* feat: add ability to downgrade membership on destroy

* add docs

* formatting

* formatting

* check membership status before downgrading

* fix lint

* fix lint

* Update github/resource_github_membership.go

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@jsifuentes @kfcampbell
feat: add ability to downgrade membership when github_membership is…
3ff8f6d 
… destroyed (integrations#1783)

* feat: add ability to downgrade membership on destroy

* add docs

* formatting

* formatting

* check membership status before downgrading

* fix lint

* fix lint

* Update github/resource_github_membership.go

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Ability to downgrade org membership to 'member' on github_membership destroy
2 participants
@jsifuentes @kfcampbell