-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce valid chars in repo name #1806
Enforce valid chars in repo name #1806
Conversation
Signed-off-by: Benoit Donneaux <ben@tergology.com>
I guess I should try to add a few test for this validation... |
Signed-off-by: Benoit Donneaux <ben@tergology.com>
Signed-off-by: Benoit Donneaux <ben@tergology.com>
Signed-off-by: Benoit Donneaux <ben@tergology.com>
Signed-off-by: Benoit Donneaux <ben@tergology.com>
I've added 2 tests: one for the max length and one for the space char.
|
I wish I could have linked this regexp with some API documentation, but I've not found any!? |
About this being a "breaking change": |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | minor | `5.31.0` -> `5.32.0` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v5.32.0`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.32.0) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.31.0...v5.32.0) #### What's Changed - Add PR templates by [@​nickfloyd](https://togithub.com/nickfloyd) in [integrations/terraform-provider-github#1803 - feat: add data source to get organization members' SAML/SCIM linked identities by [@​jsifuentes](https://togithub.com/jsifuentes) in [integrations/terraform-provider-github#1778 - fix: Github Environments Policy feature causing the provider to produce inconsistent result by [@​edheliel](https://togithub.com/edheliel) in [integrations/terraform-provider-github#1799 - Enforce valid chars in repo name by [@​btlogy](https://togithub.com/btlogy) in [integrations/terraform-provider-github#1806 #### New Contributors - [@​edheliel](https://togithub.com/edheliel) made their first contribution in [integrations/terraform-provider-github#1799 - [@​btlogy](https://togithub.com/btlogy) made their first contribution in [integrations/terraform-provider-github#1806 **Full Changelog**: integrations/terraform-provider-github@v5.31.0...v5.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4wIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: greyrock-bot <112729691+greyrock-bot[bot]@users.noreply.github.com>
* Enforce valid chars in repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> * Add dash to validate repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> * Better name validation message Signed-off-by: Benoit Donneaux <ben@tergology.com> * Test repo name max length Signed-off-by: Benoit Donneaux <ben@tergology.com> * Test space in repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> --------- Signed-off-by: Benoit Donneaux <ben@tergology.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Add docs, update tests, small changes to rulesets octoherd: delete pull_request_template.md feat: add pull_request_template.md PR template feat: add data source to get organization members' SAML/SCIM linked identities (integrations#1778) * add `github_organization_external_identities` which returns a list of github organization members and their SAML linked identity * add docs * add more fields to external_identities * docs --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com> fix: Github Environments Policy feature causing the provider to produce inconsistent result (integrations#1799) * Add deployment policy resource - Add the initial code to manage the resource - Add sample configuration used to test it TODO - Documentation - Tests * Add schema description * Fix creation of resource ID * Add tests * Add documentation * Add terraform import support * Undo example add * Fix formatting * PR feedback * fix: environment branch policy failing to find the created resource The `Read` operation of the Environments Branch Policy resource was failing to find the newly created Branch policies, due to wrongly encoded environment name. Which cause the provider to be inconsistent. This fix uses `url.PathEscape` instead of `url.QueryEscape` since we are using path parameters with the Github API in that case. Additionally 2 operations - `Read` and `Delete` don't need to use it as they receive the environment name already parsed and attempting to encode it again breaks the name. * Fix incorrect merge --------- Co-authored-by: Massimiliano Donini <massimiliano.donini@gmail.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com> Enforce valid chars in repo name (integrations#1806) * Enforce valid chars in repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> * Add dash to validate repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> * Better name validation message Signed-off-by: Benoit Donneaux <ben@tergology.com> * Test repo name max length Signed-off-by: Benoit Donneaux <ben@tergology.com> * Test space in repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> --------- Signed-off-by: Benoit Donneaux <ben@tergology.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com> Use graphql rather than rest API for Github team membership (integrations#1786) This change should provide better diffing for team membership for teams with child teams. Currently, child team members are included in the parent team's members list and so diffs are incorrect. See [Issue 1193](integrations#1193). feat: add immediate-response.yml auto responder workflow build(deps): bump peter-evans/create-or-update-comment Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 6534843181fc2aeb7f9f1cd3cd4a7b956cada2db to 716151b9579b05352dbf244d48e968d211889bbc. - [Release notes](https://github.com/peter-evans/create-or-update-comment/releases) - [Commits](peter-evans/create-or-update-comment@6534843...716151b) --- updated-dependencies: - dependency-name: peter-evans/create-or-update-comment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Add Codespaces Organization Secret Repositories Resource. Add depends_on to prevent branch policy being created before the corresponding environment (which results in an error), add more detail about the error thrown if deployment_branch_policy.custom_branch_policies is not set to true, tf fmt example build(deps): bump peter-evans/create-or-update-comment (integrations#1830) Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 716151b9579b05352dbf244d48e968d211889bbc to 38217c6b94b54c0dbbe75be237257364e2dd2e62. - [Release notes](https://github.com/peter-evans/create-or-update-comment/releases) - [Commits](peter-evans/create-or-update-comment@716151b...38217c6) --- updated-dependencies: - dependency-name: peter-evans/create-or-update-comment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> build(deps): bump golang.org/x/crypto from 0.11.0 to 0.12.0 (integrations#1829) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.11.0 to 0.12.0. - [Commits](golang/crypto@v0.11.0...v0.12.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com> build(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (integrations#1828) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](golang/oauth2@v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix: `github_repository_collaborators` - mark `invitation_ids` as changed when new user invited (integrations#1825) * fix: mark invitation_ids as changed if new user is invited * fix: documentation --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com> feat: expose SAML external identity exposed for GitHub user (integrations#1796) * create github_user_external_identity datasource * add scim information and error handling for bad username org combo * cleanup commentzs * add docs for external identity * move external identity to its own struct * add variable to make referencing external identity easier * add test * add documentation * remove old docs * add docs reference in github.erb --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com> Do not change squash_merge/merge_commit if it is not allowed in conf (integrations#1834) Co-authored-by: Keegan Campbell <me@kfcampbell.com> build(deps): bump peter-evans/create-or-update-comment Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 38217c6b94b54c0dbbe75be237257364e2dd2e62 to 5f22cb87da9514ab329de42e5462372dc19928a5. - [Release notes](https://github.com/peter-evans/create-or-update-comment/releases) - [Commits](peter-evans/create-or-update-comment@38217c6...5f22cb8) --- updated-dependencies: - dependency-name: peter-evans/create-or-update-comment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> add primary_language to repository datasource add primary_language to repository resource add test to repository datasource add docs for primary_language change add test for resource update name of testcase run linting update comment Update to go-github v54
* Enforce valid chars in repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> * Add dash to validate repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> * Better name validation message Signed-off-by: Benoit Donneaux <ben@tergology.com> * Test repo name max length Signed-off-by: Benoit Donneaux <ben@tergology.com> * Test space in repo name Signed-off-by: Benoit Donneaux <ben@tergology.com> --------- Signed-off-by: Benoit Donneaux <ben@tergology.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Resolves #1215
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!