Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Add github_repository_topics resource #1846

Merged
merged 17 commits into from
Sep 8, 2023
Merged

[FEAT]: Add github_repository_topics resource #1846

merged 17 commits into from
Sep 8, 2023

Conversation

felixlut
Copy link
Contributor

@felixlut felixlut commented Aug 17, 2023 •
edited

Resolves #1845

Before the change?

  • Repository topics can only be set via the github_repository resource

After the change?

  • Now it's also possible to work directly on the repository topics without touching anything else about the repository

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

This is not a breaking change, but usage of the topics attribute in github_repository and github_repository_topics cannot be used simultaneously

  • Yes
  • No

@felixlut felixlut marked this pull request as ready for review August 17, 2023 23:01
@nickfloyd nickfloyd added the Type: Feature New feature or request label Aug 25, 2023
@felixlut
Copy link
Contributor Author

@kfcampbell ping

kfcampbell
kfcampbell approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! You've been on fire recently.

@kfcampbell kfcampbell merged commit 5396104 into integrations:main Sep 8, 2023
3 checks passed
@felixlut felixlut deleted the resource-repository-topics branch September 9, 2023 08:38
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@felixlut @kfcampbell
[FEAT]: Add github_repository_topics resource (integrations#1846)
3838512 
* only set topics if explicitly set in github_repository resource

* Revert "only set topics if explicitly set in github_repository resource"

This reverts commit 70977ca.

* add repository_topics resource

* change repository resource to compute topics if not set

* add validation function to the repo name

* import needs to set the repository argument

* add tests

* add docs for repository_topics resource

* formatting

* make the usage of github_repository_topics clearer

* add github_repository_topic to gtihub.erb

* add link to issue showing intended usage of repository_topics resource2

* Update website/docs/r/repository.html.markdown

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add github_repository_topics resource
3 participants
@felixlut @kfcampbell @nickfloyd