[FEAT] Pick up token from gh auth login CLI
#1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the use of token persisted by GitHub CLI (https://cli.github.com) via running the `gh auth token --hostname $base_url` command and using the token from that command.
|
cc @kfcampbell @nickfloyd this one is without introducing any new module dependencies. |
kfcampbell
reviewed
Aug 24, 2023
|
@kfcampbell docs updated |
|
@kfcampbell Following up |
|
@kfcampbell @nickfloyd when can we get this released? 😀 |
|
My team is also eager to see this PR merged. thank you for your work, @nfx. |
|
I'll be taking a look at this today, if everything checks out, I'll get it merged and released as well. Thanks for the patience and contributions here! ❤️ |
nickfloyd
changed the title
gh auth login CLIgh auth login CLI
nickfloyd
approved these changes
Sep 11, 2023
nfx
added a commit
to nfx/terraform-provider-github
that referenced
this pull request
Sep 15, 2023
This PR is a follow-up to integrations#1854 GitHub CLI uses different base URLs in `~/.config/gh/hosts.yml`, so when we're using the standard base path of this provider, it doesn't align with how `gh` CLI stores the credentials. The following doesn't work: ``` $ gh auth token --hostname api.github.com > no oauth token ``` ... but the following does work correctly ``` $ gh auth token --hostname github.com > gh..<valid token> ``` attempted a workaround with ``` provider "github" { owner = "..." base_url = "github.com" } ``` But it didn't work as expected.
2 tasks
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
This PR is a follow-up to integrations#1854 GitHub CLI uses different base URLs in `~/.config/gh/hosts.yml`, so when we're using the standard base path of this provider, it doesn't align with how `gh` CLI stores the credentials. The following doesn't work: ``` $ gh auth token --hostname api.github.com > no oauth token ``` ... but the following does work correctly ``` $ gh auth token --hostname github.com > gh..<valid token> ``` attempted a workaround with ``` provider "github" { owner = "..." base_url = "github.com" } ``` But it didn't work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of token persisted by GitHub CLI (https://cli.github.com) via running the
gh auth token --hostname $base_urlcommand and using the token from that command.Resolves #1822
Before the change?
gh-authenticated machines had to pass the token via env variable:gh auth loginGITHUB_TOKEN=$(gh auth token) terraform applyAfter the change?
gh-authenticated machines do not have to pass the token via env variable:gh auth loginterraform applyDoes this introduce a breaking change?
Please see our docs on breaking changes to help!