Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display_name to github_enterprise_organization #1860

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Add display_name to github_enterprise_organization #1860

merged 2 commits into from
Aug 25, 2023

Conversation

christianfaucher
Copy link
Contributor

Resolves #1855

Before the change?

  • When an Organization Display Name is set in the settings, the github_enterprise_organization force a replacement of the organization.
  • If we are setting the ressource name equals to the Organization Display Name, the resource doesn't work at all (Could not resolve to an Organization with the login of ...)

After the change?

  • We can manage an Organization Display Name with the new attribute.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

@nickfloyd nickfloyd added the Type: Feature New feature or request label Aug 25, 2023
@nickfloyd nickfloyd merged commit c01b66a into integrations:main Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] github_enterprise_organization doens't works when a "Organization display name" is set
2 participants
@christianfaucher @nickfloyd