[bug]: url encode environment name in github_actions_environment_secret and github_actions_environment_variable data sources and resources

[anoxape]

(see #1392, #1799)

---

Before the change?

• Any attempt to create, read, update or delete a repository environment secret/variable with an environment name that contains a / or other special characters would fail.

After the change?

• Attempts to create, read, update or delete a repository environment secret/variable with an environment name that contains a / or other special characters will succeed.

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

Users of this resource may need to update their configuration to make sure that the environment name is not URL encoded twice. In other words, they may need to change e.g.:

resource "github_actions_environment_variable" "this" {
  environment   = urlencode("environment/test")
  repository    = "my-repo"
  variable_name = "example_variable_name"
  value         = "example_variable_value"
}

into:

resource "github_actions_environment_variable" "this" {
  environment   = "environment/test"
  repository    = "my-repo"
  variable_name = "example_variable_name"
  value         = "example_variable_value"
}

assuming they have environment names that contain special characters.

---

[nickfloyd]

Thanks @anoxape ❤️

[saez0pub]

The public key can't be found anymore on action environment secrets :( https://github.com/integrations/terraform-provider-github/blob/680c66e184d858bdc409c51a004d5a4cb1cce80d/github/resource_github_actions_environment_secret.go#L202C77-L202C77