Fixed invalid default hostname for gh auth token #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in the event that no base_url is given to the provider configuration, the tokenFromGhCli() function will set a default hostname of "api.github.com" which is invalid for the "gh auth token" cli command. Instead, the proper default hostname should be "github.com" which is correct and works.
nickfloyd
approved these changes
Sep 21, 2023
This was referenced Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1905
Before the change?
The current default hostname for getting the authentication token from GitHub CLI is "api.github.com"
After the change?
The default hostname is set to "github.com" which is the correct default hostname for
gh auth login.Does this introduce a breaking change?
There should be no breaking changes contained in this PR.