Empty ruleset required_deployment_environments is now valid #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
reviewed
Oct 20, 2023
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…ions#1942) * Empty ruleset required_deployment_environments is now valid * Update github/respository_rules_utils.go --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1915
Before the change?
DefaultFuncfixed the issue for existing rulesets but not new ones.After the change?
DefaultFuncfrom this field so that you can't define an empty block forrequired_deploymentsrule. Ifrequired_deployment_environmentsis empty then we know we'll have anilinterface, and we manually set the value to an empty slice of interfaces, otherwise we just cast the value to a slice of interfaces as usual.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!