Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] missing environment name encoding for secrets #1969

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

saez0pub
Copy link
Contributor

Resolves #1960


Before the change?

  • secrets in environment name needing encoding were in error (The test was already failing because of this)

After the change?

  • secrets in environment name needing encoding are manageable

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features) (I fixed the failing test)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming this fixes the failing integration tests. Thanks for the attention to detail!

@kfcampbell kfcampbell merged commit 020f217 into integrations:main Oct 25, 2023
3 checks passed
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Impossible to create a secret in an environment name needing encoding since #1897
2 participants