Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dismissal_apps #1984

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Add support for dismissal_apps #1984

merged 4 commits into from
Nov 7, 2023

Conversation

jporzucek
Copy link
Contributor

Resolves #1983

Before the change?

  • dismissal_apps IS NOT supported for branch protection resource.

After the change?

  • dismissal_apps IS supported for branch protection resource.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kfcampbell
Copy link
Member

The changed integration test is failing for me:

    testing.go:705: Step 0 error: Check failed: 6 errors occurred:
        	* Check 5/10 error: github_branch_protection_v3.test: Attribute 'required_pull_request_reviews.0.dismissal_users' not found
        	* Check 6/10 error: github_branch_protection_v3.test: Attribute 'required_pull_request_reviews.0.dismissal_teams' not found
        	* Check 7/10 error: github_branch_protection_v3.test: Attribute 'required_pull_request_reviews.0.dismissal_apps' not found
        	* Check 8/10 error: github_branch_protection_v3.test: Attribute 'required_pull_request_reviews.0.bypass_pull_request_allowances.users' not found
        	* Check 9/10 error: github_branch_protection_v3.test: Attribute 'required_pull_request_reviews.0.bypass_pull_request_allowances.teams' not found
        	* Check 10/10 error: github_branch_protection_v3.test: Attribute 'required_pull_request_reviews.0.bypass_pull_request_allowances.apps' not found

Can you reproduce this error?

@jporzucek
Copy link
Contributor Author

@kfcampbell Should be good now, for some reason bypass_pull_request_allowances.teams didn't accept mock team's name.

kfcampbell
kfcampbell approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it's passing now, thank you!

@kfcampbell kfcampbell merged commit edf5bda into integrations:main Nov 7, 2023
3 checks passed
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@jporzucek @kfcampbell
Add support for dismissal_apps (integrations#1984)
2a47a41 
* Add support for dismissal_apps

* Update test

* Fix tests

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Support dismissal_apps for github_branch_protection resource
2 participants
@jporzucek @kfcampbell