Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update repository_ruleset r doc #1986

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

anastasiiakozlova245
Copy link
Contributor

@anastasiiakozlova245 anastasiiakozlova245 commented Oct 29, 2023

Update github_repository_ruleset.rules.required_status_checks.required_check property to define nested dependency more clear

Resolves #1893


Before the change?

  • Under the "Rules" block section a nested property github_repository_ruleset.rules.required_status_checks.required_check is defined as required_status_checks.required_check, which causes unclarity.

After the change?

  • A nested property github_repository_ruleset.rules.required_status_checks.required_check is defined as rules.required_status_checks.required_check under the "Rules" block section.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kfcampbell kfcampbell merged commit 93cf560 into integrations:main Nov 7, 2023
3 checks passed
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants