add support for web commit sign off #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rumen Vasilev <git@rumenvasilev.com>
Signed-off-by: Rumen Vasilev <git@rumenvasilev.com>
kfcampbell
reviewed
Nov 10, 2023
| @@ -678,6 +685,7 @@ func resourceGithubRepositoryRead(d *schema.ResourceData, meta interface{}) erro | |||
| d.Set("allow_squash_merge", repo.GetAllowSquashMerge()) | |||
| d.Set("allow_update_branch", repo.GetAllowUpdateBranch()) | |||
| d.Set("delete_branch_on_merge", repo.GetDeleteBranchOnMerge()) | |||
| d.Set("web_commit_signoff_required", repo.GetWebCommitSignoffRequired()) | |||
There was a problem hiding this comment.
Shouldn't this be set somewhere in the Create/Update methods as well?
There was a problem hiding this comment.
Did I miss adding it somewhere? I’ve tested this feature and it works as expected (adding, removing, updating the setting).
Is it possible that you’re asking for the other PR (the bug for gitcommit paginated call)?
|
@kfcampbell is there a reason you are not merging this? |
|
It slipped through the cracks for me; apologies. I'll get it merged and released soon. |
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* add support for web commit sign off Signed-off-by: Rumen Vasilev <git@rumenvasilev.com> * include test assertion Signed-off-by: Rumen Vasilev <git@rumenvasilev.com> --------- Signed-off-by: Rumen Vasilev <git@rumenvasilev.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2006
Before the change?
After the change?
web_commit_signoff_requiredallows you to toggle this on or off (off by default).Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!