Fix: add GitHub repository collaborators when repository name contains the org name #2013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1658
Before the change?
Adding a github_repository_collaborator like below:
Terraform apply for it returns an error with a status code 404 because the
repository
attribute is used as it is. During the API call the repo looks something likehttps://api.github.com/repos/my-org/my-org/my-repo/collaborators/USERNAME
instead ofhttps://api.github.com/repos/my-org/my-repo/collaborators/USERNAME
In the request, the org name is used twice which is the cause of the 404 error.
After the change?
With the change, all the requests made to Github API contains only repository name.
Note
The repository supplied through the TF file is kept as it to avoid any state diff issue. The repository name is only pruned during the Github API Calls.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!