Fix type assertion failure on github_dependabot_organization_secret_repositories.selected_repository_ids #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A repository ID is not an int64 as can be seen on https://github.com/integrations/terraform-provider-github/blob/46650cb363ded7c10bc780998fa3166d3dd63daf/github/data_source_github_repository.go#L216
rene-bos
force-pushed
the
fix-dependabot-organization-secret-repositories
branch
from
5c25c56
to
7845bc2
Compare
nickfloyd
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A repository ID is not an int64 as can be seen on
terraform-provider-github/github/data_source_github_repository.go
Line 216 in 46650cb
The code is now the same as other places where
selected_repository_idsis used (for example here).Locally tested with our Terraform project.
Resolves #2028
Before the change?
selected_repository_idsare asserted of being of theint64type.After the change?
selected_repository_idsare casted to anint64.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!