Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Correctly handle environments with names containing spaces #2072

Merged
merged 3 commits into from
Jan 5, 2024
Merged

[Fix] Correctly handle environments with names containing spaces #2072

merged 3 commits into from
Jan 5, 2024

Conversation

nint8835
Copy link
Contributor

Resolves #1545

Before the change?

  • Creating an environment with a space in the name will result with an environment with a plus in the name instead
  • Attempting to import an environment with a name containing a space will result in a not found error

After the change?

  • Creating an environment with a space in the name will correctly create an environment with a space in the name
  • Importing an environment with a name containing a space will succeed

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

kfcampbell
kfcampbell approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kfcampbell kfcampbell merged commit d3bc5ba into integrations:main Jan 5, 2024
3 checks passed
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@nint8835 @kfcampbell
[Fix] Correctly handle environments with names containing spaces (int…
3811c40 
…egrations#2072)

* Use url.PathEscape to encode environment names instead of url.QueryEscape

* Update all environment tests to include spaces in environment names

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Using spaces in environment names does not work
2 participants
@nint8835 @kfcampbell