Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid getting user when anonymous #2074

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Avoid getting user when anonymous #2074

merged 3 commits into from
Jan 5, 2024

Conversation

mnencia
Copy link
Contributor

@mnencia mnencia commented Dec 27, 2023

Resolves regressions #2008 and #2014 introduced in #1029

Before the change?

  • When anonymous, you always obtain the following initialization error
    Error: GET https://api.github.com/user: 401 Requires authentication []
    

After the change?

  • When anonymous, it works without errors.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

mnencia and others added 2 commits December 27, 2023 10:58
Resolves regressions #2008 and #2014 introduced in #1029

Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@kfcampbell kfcampbell merged commit 7411f66 into integrations:main Jan 5, 2024
3 checks passed
@mnencia mnencia deleted the avoid-anonymous-get-user branch January 6, 2024 09:36
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Resolves regressions integrations#2008 and integrations#2014 introduced in integrations#1029

Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants