Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose terminal subcommand #75

Merged
merged 2 commits into from Apr 23, 2022

Conversation

mattwiller
Copy link
Contributor

For use cases where only the final subcommand in the sequence needs to be run
(e.g. git remote add just runs the add subcommand of remote), it would be
useful to identify that subcommand directly. Since that pointer is already
helpfully stored in the parser, simply exposing it via a method worked nicely.

For use cases where only the final subcommand in the sequence needs to be run
(e.g. `git remote add` just runs the add subcommand of remote), it would be
useful to identify that subcommand directly.  Since that pointer is already
helpfully stored in the parser, simply exposing it via a method worked nicely.
Copy link
Owner

@integrii integrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, but I would like to change Terminal to Trailing here if we could. I submitted suggestions to edit your change to Trailing terminology - you just have to hit accept on it.

parser.go Outdated Show resolved Hide resolved
flaggy_test.go Outdated Show resolved Hide resolved
flaggy_test.go Outdated Show resolved Hide resolved
parser.go Show resolved Hide resolved
Co-authored-by: Eric Greer <ericgreer@gmail.com>
Copy link
Owner

@integrii integrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to come back and contribute! I like it!

@integrii integrii merged commit 50d0cd8 into integrii:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants