Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ByteSizeLong() instead of deprecated ByteSize() #476

Closed
wants to merge 1 commit into from

Conversation

siburu
Copy link

@siburu siburu commented Dec 16, 2019

Since protobuf 3.11.0, deprecated codes are annotated and warned.
protocolbuffers/protobuf#6612

"make psw" fails because of uses of deprecated method ByteSize().
This PR simply replaces all calls to ByteSize() with ByteSizeLong().

@llly
Copy link
Contributor

llly commented Dec 16, 2019

protobuf 3.11.0 and later is incompatible with early releases.
We can not change these functions because we must support the default protobuf provided by the OSes referred to in Readme.
Best solution is changing CXXFLAGS to disable the warings and it works for all protobuf version.

@siburu
Copy link
Author

siburu commented Dec 17, 2019

Thank you! Now I understand the situation.
I will change this PR to add "-wno-deprecated" flag for protobuf-related stuffs.

@llly
Copy link
Contributor

llly commented Dec 17, 2019

We plan to fix this compatibility issue in next major release.

@siburu
Copy link
Author

siburu commented Dec 17, 2019

Thanks. Okay, is it better to just wait for it? Is the release relatively close?

@llly
Copy link
Contributor

llly commented Dec 18, 2019

probably in early Jan. 2020.

@siburu
Copy link
Author

siburu commented Dec 18, 2019

Very close. Thank you!!
I will wait for it while following your suggestion to suppress warnings.

@siburu siburu closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants