Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add shell.nix and pin down nixpkgs revision #616

Draft
wants to merge 2 commits into
base: sgx_2.10_reproducible
Choose a base branch
from
Draft

[WIP] Add shell.nix and pin down nixpkgs revision #616

wants to merge 2 commits into from

Conversation

sbellem
Copy link
Contributor

@sbellem sbellem commented Oct 16, 2020

This pull request is a work in progress, to help explain the question raised in #612.

@sbellem sbellem changed the title Add shell.nix and pin down nixpkgs revision [WIP] Add shell.nix and pin down nixpkgs revision Oct 16, 2020
@sbellem sbellem mentioned this pull request Oct 16, 2020
Open
xiangquanliu
xiangquanliu reviewed Oct 19, 2020
View reviewed changes
Copy link
Contributor

@xiangquanliu xiangquanliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these changes, how does shell.nix run in the container?

@sbellem
Add missing shell.nix in docker image
5f6f7ba 
Remove unused line in shell.nix
@sbellem
Copy link
Contributor Author

sbellem commented Oct 19, 2020

For these changes, how does shell.nix run in the container?

The line in which the shell.nix file is copied into the image was omitted by mistake. I added it in 5f6f7ba.

The last line of the image, in which nix-shell is invoked, if I am not mistaken, installs the dependencies, and populates the nix store under /nix/store/.

@sbellem sbellem marked this pull request as draft June 10, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangquanliu xiangquanliu xiangquanliu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbellem @xiangquanliu