Fix ocaml compilation in ubuntu 22.04 LTS. #30
Conversation
|
20240206083735.log |
| SIGSTKSZ may not be a compile-time constant. | ||
| It is no longer possible to statically allocate the alternate | ||
| signal stack for the main thread. | ||
|
|
There was a problem hiding this comment.
please add reference to the upstream PR in this patch. so that we can reconsider this when the changes come in.
There was a problem hiding this comment.
added, also provide updated build log in ubuntu 22 LTS
20240219023941.log
kjlau0112
force-pushed
the
fix_glibc_patch
branch
from
90112f5
to
829fe5d
Compare
| signal stack for the main thread. | ||
|
|
||
| Upstream-Status:Backport | ||
| Reference: https://github.com/ocaml/ocaml/pull/10266 |
There was a problem hiding this comment.
@AdithyaBaglody added for your reference.
| SIGSTKSZ may not be a compile-time constant. | ||
| It is no longer possible to statically allocate the alternate | ||
| signal stack for the main thread. | ||
|
|
There was a problem hiding this comment.
added, also provide updated build log in ubuntu 22 LTS
20240219023941.log
recipes-devtools/ocaml/files/0001-Update-ocaml-native-to-fix-upstream-glic-build.patch
Outdated
Show resolved
Hide resolved
recipes-devtools/ocaml/files/0001-Update-ocaml-native-to-fix-upstream-glic-build.patch
Outdated
Show resolved
Hide resolved
| + if (stk.ss_sp == NULL) return -1; | ||
| + stk.ss_size = SIGSTKSZ; | ||
| + stk.ss_flags = 0; | ||
| + return sigaltstack(&stk, NULL); |
There was a problem hiding this comment.
above review comment 1 we have removed the check and from here we are calling sending signal , seems we need the previous check based on this event.
There was a problem hiding this comment.
above review comment 1 we have removed the check and from here we are calling sending signal , seems we need the previous check based on this event.
The latest changes have removed this changes, let re-align on ocaml/ocaml@17df117 changes
Upstream glibc broke ocaml compilation in ubuntu 21 onward. Backport upstream ocaml modification from commit:17df117b4939486d3285031900587afce5262c8c to address the build issue and the memory leaks issue post ocaml/ocaml#10266 modification. Reference:ocaml/ocaml@17df117 Signed-off-by: Karn Jye Lau <karn.jye.lau@intel.com>
kjlau0112
force-pushed
the
fix_glibc_patch
branch
from
829fe5d
to
6b7a1ff
Compare
|
20240222045957.log |
|
@pchand20 Can you please merge this PR as review from your end completed? |
Upstream glibc broke ocaml compilation in ubuntu
21 onward. Backport upstream ocaml modification
from commit:17df117b4939486d3285031900587afce5262c8c
to address the build issue and the memory leaks issue
post ocaml/ocaml#10266 modification.