Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Auto mod refactor #1543

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

mAxYoLo01
Copy link
Contributor

@mAxYoLo01 mAxYoLo01 commented Aug 25, 2023

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Big PR to make modifications to the Auto Mod classes that currently are missing attributes, have wrong names etc..

Changes

AutoModUpdate was triggered by the AutoModDelete event and vice versa (typo in the processors)
Added missing Triggers and Actions and added/modified some of its attributes
Renamed the AutoModLanguageType enum to KeywordPresetType (as it is called in DDocs)

Related Issues

#1540

Test Scenarios

@interactions.listen()
async def my_function(event: interactions.events.AutoModUpdated):
    print("UPDATED:", event)

@interactions.listen()
async def my_function2(event: interactions.events.AutoModCreated):
    print("CREATED:", event)

@interactions.listen()
async def my_function3(event: interactions.events.AutoModDeleted):
    print("DELETED:", event)

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@LordOfPolls
Copy link
Contributor

This is incredibly breaking
You guys were discussing a v6 - this pr will be on hold until the scope of 6.0.0 is established

Feel free to make a new PR resolving the underlying issue, but the bulk rename will have to wait

@LordOfPolls LordOfPolls added the on hold This issue/PR is on hold pending higher priority issues/PRs label Aug 26, 2023
@mAxYoLo01 mAxYoLo01 mentioned this pull request Aug 26, 2023
13 tasks
@eightween eightween added enhancement New feature or request breaking This contains breaking changes labels Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This contains breaking changes enhancement New feature or request on hold This issue/PR is on hold pending higher priority issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants