Update voice recording example #1605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing example does not work due to missing deferral and missing message body, this fixes both. Signed-off-by: Jason Dilworth <hello@jasondilworth.co.uk>
AstreaTSS
reviewed
Feb 21, 2024
| voice_state = await ctx.author.voice.channel.connect() | ||
|
|
||
| # Start recording | ||
| await voice_state.start_recording() | ||
| await asyncio.sleep(10) | ||
| await voice_state.stop_recording() | ||
| await ctx.send(files=[interactions.File(file, file_name="user_id.mp3") for user_id, file in voice_state.recorder.output.items()]) | ||
| await ctx.send("Here are your recordings", files=[interactions.File(file, file_name="user_id.mp3") for user_id, file in voice_state.recorder.output.items()]) |
There was a problem hiding this comment.
The content here shouldn't be needed. What error are you getting here?
There was a problem hiding this comment.
I cannot test again until a bit later, but there was an error about the message not being empty.
There was a problem hiding this comment.
It's because you didn't actually send/capture any audio. You need to talk and should visually see that your microphone is activating. Without any text or file attachments, the message was empty, hence the error.
files=[interactions.File(file, file_name=f"{user_id}.mp3") for user_id, file in voice_state.recorder.output.items()]
if len(files) > 0:
await ctx.send(files=files)
else:
await ctx.send("No audio was recorded.")
|
Putting on hold until requests are met and satisfied |
eightween
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
The existing example does not work due to missing deferral and missing message body, this fixes both.
Changes
ctx.defer()at beginning of exampleRelated Issues
Test Scenarios
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files