fix: add extension name before loading in callbacks #1680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This one's on me - I probably should have done more testing.
Anyways, while making #1678, I did not account for, when adding prefixed commands in extensions, that the extension's
extension_name
does not exist yet. This variable is used when registering prefixed commands, and so an error appears:I... don't know how prefixed command registering before #1678 worked, since the old version still should register prefixed commands before
extension_name
exists, but async funkiness, I suppose. Regardless, this PR fixesextension_name
not existing by adding it in earlier.Changes
extension_name
assignment to before adding callbacks, instead of after.Related Issues
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files