Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include handler for payment_pointer.web_monetization webhook event in Mock ASE #2057

Closed
2 tasks done
sabineschaller opened this issue Oct 19, 2023 · 4 comments · Fixed by #2659
Closed
2 tasks done

Include handler for payment_pointer.web_monetization webhook event in Mock ASE #2057

sabineschaller opened this issue Oct 19, 2023 · 4 comments · Fixed by #2659
Assignees
@lengyel-arpad85
Labels
good first issue Good for newcomers hacktoberfest stale

Comments

@sabineschaller
Copy link
Member

sabineschaller commented Oct 19, 2023 •
edited by lengyel-arpad85

Context

The Mock ASE currently does not handle payment_pointer.web_monetization webhook events. Since it should also serve as a reference for actual integrators, all webhook events should be handled.

Note: As of the creation of this issue, it is still called payment_pointer. However, we are in the process of changing this to wallet_address.

Todos

  • include handler here
  • handle event case here
@manulpatel
Copy link

Hello @sabineschaller! I would like to work on this issue. Could you please assign me?

@sabineschaller
Copy link
Member Author

Hi @manulpatel , it's yours 🙂

@Shubham2503
Copy link
Contributor

Hey team, @sabineschaller @manulpatel,
Can I take this one, if this issue is still open?

@sabineschaller sabineschaller mentioned this issue Nov 2, 2023
Closed
4 tasks
@BlairCurrey BlairCurrey mentioned this issue Nov 3, 2023
Closed
4 tasks
@BlairCurrey
Copy link
Contributor

BlairCurrey commented Nov 27, 2023 •
edited

Currently the docs indicate calling the WithdrawEventLiquidity endpoint in this webhook handler. However, this handler is being deprecated and we should be able to use createWalletAddressWithdrawal instead.

Also, this webhook never actually fires. We might be able to manually test by:

  • changing walletAddressService.create to do something like this: 70a03ad
  • create a new wallet address via postman
  • call triggerWalletAddressEvents via postman which should trigger handleWalletAddressWebMonetization

@sabineschaller sabineschaller changed the title Include handler for payment_pointer.web_montization webhook event in Mock ASE Include handler for payment_pointer.web_monetization webhook event in Mock ASE Dec 5, 2023
@mkurapov mkurapov added the stale label Mar 5, 2024
@njlie njlie assigned lengyel-arpad85 and unassigned manulpatel Apr 9, 2024
@lengyel-arpad85 lengyel-arpad85 mentioned this issue Apr 12, 2024
Merged
5 tasks
@lengyel-arpad85 lengyel-arpad85 linked a pull request May 3, 2024 that will close this issue
feat(2057): Include handler for payment_pointer.web_monetization webhook event #2659
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengyel-arpad85 lengyel-arpad85

Labels
good first issue Good for newcomers hacktoberfest stale
Projects
Rafiki
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(2057): Include handler for payment_pointer.web_monetization webhook event interledger/rafiki
6 participants
@BlairCurrey @mkurapov @sabineschaller @Shubham2503 @manulpatel @lengyel-arpad85