Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2057): Include handler for payment_pointer.web_monetization webhook event #2659

Merged
merged 6 commits into from May 14, 2024
Merged

feat(2057): Include handler for payment_pointer.web_monetization webhook event #2659

merged 6 commits into from May 14, 2024

Conversation

lengyel-arpad85
Copy link
Contributor

@lengyel-arpad85 lengyel-arpad85 commented Apr 12, 2024 •
edited

Changes proposed in this pull request

  • Includes handler for payment_pointer.web_monetization webhook event

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@lengyel-arpad85 lengyel-arpad85 self-assigned this Apr 12, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 05631c5
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/663a43d6542b7c00082a8a0c

@lengyel-arpad85 lengyel-arpad85 changed the title Include handler for payment_pointer.web_monetization webhook event feat(2057): Include handler for payment_pointer.web_monetization webhook event Apr 12, 2024
@lengyel-arpad85 lengyel-arpad85 linked an issue May 3, 2024 that may be closed by this pull request
Include handler for payment_pointer.web_monetization webhook event in Mock ASE #2057
Closed
2 tasks
sabineschaller
sabineschaller previously approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@sabineschaller sabineschaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good now. Thank you!

mkurapov
mkurapov reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic in the MASE looks good, just need to update how we get data from the webhook and how we call the API

localenv/mock-account-servicing-entity/app/lib/webhooks.server.ts Outdated Show resolved Hide resolved
localenv/mock-account-servicing-entity/app/lib/webhooks.server.ts Outdated Show resolved Hide resolved
@lengyel-arpad85 lengyel-arpad85 merged commit d9b2442 into main May 14, 2024
42 checks passed
@lengyel-arpad85 lengyel-arpad85 deleted the 2057-include-web-monetazation-webhook-even branch May 14, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@njlie njlie Awaiting requested review from njlie

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

Assignees

@lengyel-arpad85 lengyel-arpad85

Labels
pkg: mock-account-service-lib pkg: mock-ase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include handler for payment_pointer.web_monetization webhook event in Mock ASE
3 participants
@lengyel-arpad85 @mkurapov @sabineschaller