feat(frontend): admin ui changes #2716
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
| <a | ||
| className='tooltip' | ||
| href='https://rafiki.dev/concepts/interledger-protocol/peering/' | ||
| > |
There was a problem hiding this comment.
This would apply to all these links:
Should it open in a new tab? user likely wants to resume whatever they were doing here after visiting this site for more context.
There was a problem hiding this comment.
Non-blocking, just some food for thought.
From the task I was expecting a tooltip more like this. Perhaps in an info icon like in this example. As opposed to descriptions under the field. I guess I can see a case for that too though, if we wanted the extra information to be more prominent. An info icon tooltip would be a bit less busy though IMO and keep the error message closer to the input as well. How it currently looks, for context:
| a.tooltip { | ||
| color: revert; | ||
| text-decoration: revert; | ||
| } |
There was a problem hiding this comment.
My understanding is this restores some original styling for a links that tailwind strips out.
This seems like a good way to do it. We've handled this differently elsewhere (a bunch of tailwind utility classnames) but I think what you've done here is simpler and easier to use.
If it makes sense to you, please merge this PR which standardizes on this method: #2719. I also renamed the class to default-link and updated reference since it would apply to more than tooltips.
There was a problem hiding this comment.
thanks for the review, merged in
| @@ -38,6 +39,9 @@ export const Input = forwardRef<HTMLInputElement, InputProps>( | |||
| {...props} | |||
| /> | |||
| </div> | |||
| {description ? ( | |||
| <div className='font-medium text-sm'>{description}</div> | |||
There was a problem hiding this comment.
| <div className='font-medium text-sm'>{description}</div> | |
| <div className='font-light italic mt-1 text-sm'>{description}</div> |
maybe? to give a bit more visual separation
Changes proposed in this pull request
WebhooktoWebhook Data.AssetandPeertabs.Peersection with links to documentation.Context
Fixes #2681.
Checklist
fixes #number