Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize default a link styling #2719

Merged

Conversation

BlairCurrey
Copy link
Contributor

Changes proposed in this pull request

  • renames tooltip css class to default-link
  • applies to pre-existing a elements that used a different method to achieve default(ish) styling

Context

Suggestion for PR #2716

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@BlairCurrey BlairCurrey requested a review from njlie May 10, 2024 17:34
@github-actions github-actions bot added the pkg: frontend Changes in the frontend package. label May 10, 2024
Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, those other elements look much cleaner now. Thanks!

@BlairCurrey BlairCurrey merged commit 48805ed into nl/2681/admin-ui-changes May 13, 2024
38 checks passed
@BlairCurrey BlairCurrey deleted the bc/2681/suggestion/admin-ui-changes branch May 13, 2024 16:19
njlie added a commit that referenced this pull request May 14, 2024
* feat(frontend): admin ui changes

* refactor: standardize default a link styling (#2719)

---------

Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: frontend Changes in the frontend package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants