feat(auth)!: move consent interaction to different port #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions
bot
added
type: source
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
golobitch
force-pushed
the
2649-auth-move-interaction-routes-to-a-different-port-1
branch
from
a239a55
to
55effbf
Compare
golobitch
force-pushed
the
2649-auth-move-interaction-routes-to-a-different-port-1
branch
from
55effbf
to
4a82474
Compare
github-actions
bot
added
type: tests
njlie
reviewed
May 10, 2024
golobitch
force-pushed
the
2649-auth-move-interaction-routes-to-a-different-port-1
branch
from
09f76e1
to
3d169e6
Compare
mkurapov
reviewed
May 15, 2024
packages/documentation/src/content/docs/concepts/open-payments/grant-interaction.mdx
Show resolved
Hide resolved
njlie
previously approved these changes
May 21, 2024
mkurapov
reviewed
May 21, 2024
| const acceptResponse = await fetch( | ||
| `${url.toString()}grant/${interactId}/${nonce}/accept`, | ||
| `${deps.sendingASE.config.interactionServer}/grant/${interactId}/${nonce}/accept`, |
There was a problem hiding this comment.
final thing, I think we just need to expose interactionServer on the TestConfig interface
There was a problem hiding this comment.
Let me check that. I also need to rebase to main
golobitch
force-pushed
the
2649-auth-move-interaction-routes-to-a-different-port-1
branch
from
a512b22
to
c0fb04c
Compare
Accept and reject interaction choices should not be exposed. but other routes can and must be exposed. This is why we need to move the choice routes to different port BREAKING CHANGE: Routes for accepting and rejecting choice are no longer exposed. Ideally, this must be done through ASE backend service that checks for authentication / authorization
Co-authored-by: Max Kurapov <max@interledger.org>
golobitch
force-pushed
the
2649-auth-move-interaction-routes-to-a-different-port-1
branch
3 times, most recently
from
0d1037e
to
ecd799b
Compare
golobitch
force-pushed
the
2649-auth-move-interaction-routes-to-a-different-port-1
branch
from
ecd799b
to
4135dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
fixes #2649
Checklist
fixes #number