Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display WM icon differently if website is/isn't monetized #79

Closed
raducristianpopa opened this issue Jan 16, 2024 · 8 comments · Fixed by #234
Closed

Display WM icon differently if website is/isn't monetized #79

raducristianpopa opened this issue Jan 16, 2024 · 8 comments · Fixed by #234
Assignees
@dianafulga
Labels
area: popup Improvements or additions to extension popup
Milestone
WM extension 1.0....

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented Jan 16, 2024 •
edited by tselit

Context

When a user has the WM extension installed, and they have successfully connected their wallet address to the extension, then the icon of the extension must look different depending on whether the user is currently visiting a web monetized website or not.

When a user is visiting a site:

  • If the site has no monetization tag with a valid wallet address url:
  • If the site has at least one monetization tag with a valid wallet address url:
  • If extension has web monetization globally disabled:
@raducristianpopa raducristianpopa added the area: background Improvements or additions to extension background script label Jan 16, 2024
@raducristianpopa raducristianpopa changed the title Add monetization service Add extension storage wrapper Jan 16, 2024
@raducristianpopa raducristianpopa changed the title Add extension storage wrapper Add monetization service Jan 16, 2024
@raducristianpopa raducristianpopa changed the title Add monetization service Add listeners service Jan 16, 2024
@tselit
Copy link

tselit commented Feb 15, 2024

Please update the context for us @ionutanin

@ionutanin
Copy link
Contributor

as @raducristianpopa suggested:
we should update the background message handler to use switch case rather than use separate files for each message

@tselit tselit added area: popup Improvements or additions to extension popup and removed area: background Improvements or additions to extension background script labels Apr 2, 2024
@tselit tselit changed the title Add listeners service Display WM icon differently if website is/isn't monetized Apr 2, 2024
@tselit tselit added this to the WM extension 1.0.0-beta milestone Apr 4, 2024
@tselit
Copy link

tselit commented Apr 10, 2024

We decided to repurpose this ticket, so please disregard any of the comments prior to 10 Apr 2024

@tselit
Copy link

tselit commented Apr 16, 2024

Should be ready for peer review on Wed, 17 Apr. Aiming to merge by the end of this week, 19 Apr.

@dianafulga dianafulga mentioned this issue Apr 18, 2024
Merged
@tselit
Copy link

tselit commented Apr 30, 2024

Review feedback shared today. Aiming to resolve and have ready for final merging on Thurs, 2 May.

@tselit
Copy link

tselit commented May 7, 2024 •
edited

Issue 1 - PR feedback from Max:

  • when WM is globally disabled
  • then navigate to a WMized website
  • then enable WM globally
  • expected behaviour: the WM icon should be updated to show that the site is monetized but currently the WM ext icon appears as though the site is NOT WMized

@tselit
Copy link

tselit commented May 7, 2024 •
edited

Secondary issue found:

  • the state the that the icon was in on the previously opened tab remains (or is carried over) when a new (blank) tab is opened (this can be confusing as it may appear as WM is active or disabled, or whatever the previously opened site's WM status was).
  • still under discussion

@tselit
Copy link

tselit commented May 9, 2024 •
edited

Related to Issue 1 above: the WM event is not triggered when re-enabling WM globally. This will be addressed as part of this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianafulga dianafulga

Labels
area: popup Improvements or additions to extension popup
Projects
Web Monetization Extension
Status: Done
Milestone
WM extension 1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

feat: Update icon interledger/web-monetization-extension
4 participants
@ionutanin @dianafulga @raducristianpopa @tselit