feat: Update icon #234
Merged
feat: Update icon #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion into ia--monetization-flow
github-actions
bot
added
area: content
Extension builds preview
|
){kind=icon}
){kind=icon}
…n-extension into df--update-icon
mkurapov
reviewed
May 2, 2024
Comment on lines
326
to
329
| if (walletAddress) { | ||
| startMonetization({ requestId, walletAddress }) | ||
| isTabMonetized({ value: true }) | ||
| } |
There was a problem hiding this comment.
We should bulk send (for start, resumse, stop) all the link tags that are in the page. This way we can avoid sending multiple events. With the current approach we send two START_MONETIZATION and two TAB_MONETIZED when a new link tag is added.
added 2 commits
May 10, 2024 16:25
github-actions
bot
removed
the
area: popup
|
after
Working now (maybe just outdated pnpm or something else on my end) |
mkurapov
approved these changes
May 13, 2024
There was a problem hiding this comment.
The icon change is working for me correctly, approving.
One comment I have is regarding @raducristianpopa 's comment: #234 (comment)
it seems like the start/stop/resume events are still being fired once per tag, maybe this can be made into a separate issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79