Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build and push Docker image #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wilsonianb
Copy link
Contributor

This would require us to add interledgerjs(?) docker hub account credentials to circleci

@wilsonianb wilsonianb requested a review from sharafian July 8, 2019 15:58
@matdehaast
Copy link

@adrianhopebailie can do that for you @wilsonianb. I think we do have it already setup for some other repos already.

Would it not make more sense for the main moneyd repo to have a docker container and then pass options/arguments in for the specific uplinks? Put differently, why would the uplink need its own docker image?

@sharafian
Copy link

Would it not make more sense for the main moneyd repo to have a docker container and then pass options/arguments in for the specific uplinks? Put differently, why would the uplink need its own docker image?

Moneyd would need to be packaged with all the uplinks for that to work

Copy link

@sharafian sharafian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianhopebailie can you add the credentials for this to circle? then it can be merged

@wilsonianb
Copy link
Contributor Author

At Matt's suggestion, I'm going to try having Dockerhub handle the image building.
I'll reopen when that's ready.

@wilsonianb wilsonianb closed this Aug 1, 2019
@wilsonianb
Copy link
Contributor Author

TIL you can't reopen a pull request if you've force pushed since closing it

@wilsonianb
Copy link
Contributor Author

I've created a Dockerhub repo and configured it to autobuild and publish images for master and tags.
https://hub.docker.com/r/interledgerjs/moneyd-xrp

Moneyd would need to be packaged with all the uplinks for that to work

Would including moneyd and the uplinks in the interledgerjs monorepo make that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants