Build/upgrade pnpm@6.35.1 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfixes 11/11/22
…set-release/main chore: update versions
🦋 Changeset detectedLatest commit: 4cc347f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ilo-ui-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ilo-ui-twig ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
): fix issue where plus was not showing up until user interacted
…ational-labour-organization/designsystem into build/upgrade-pnpm-6.35.1
|
@justintemps Is there a way for us to do a dry run of this on Netlify to make sure the build doesn't break? |
|
@johnpauldavis Yea, it's already done, that's what the Deploy previews are for. |
johnpauldavis
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm and changeset don't appear to be changing
workspace:*to the latest version of the package in all cases. This problem is described here and the recommended fix is to upgrade pnpm.Here I'm recommending we upgrade to 6.35.1, which is the latest release for version 6, rather than version 7 with which we've encountered build issues in the past.