Merge pull request #8685 from cdrini/revert/check-options

Revert blue "Check Options" but keep click behaviour
internetarchive · Jan 4, 2024 · bf28a89 · bf28a89
2 parents 2ad32a9 + 77a644c
commit bf28a89
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 14 deletions.
diff --git a/openlibrary/macros/CheckOptions.html b/openlibrary/macros/CheckOptions.html
diff --git a/openlibrary/macros/LoanStatus.html b/openlibrary/macros/LoanStatus.html
@@ -113,13 +113,13 @@
       $:macros.BookSearchInside(ocaid)
 
 $else:
-  $# Only render NotInLibrary on an edition's page, for that specific edition.
+  $# Only render clickable NotInLibrary when not on an edition's page, for that specific edition.
   $# secondary_action means we're on a book page and it's the button under the cover image.
   $ key = doc.key if is_edition else work_key
   $if (is_edition and is_book_page) or secondary_action:
-      $:macros.NotInLibrary()
+      $:macros.NotInLibrary(link=None)
   $else:
-      $:macros.CheckOptions(key)
+      $:macros.NotInLibrary(link=key)
 
 $:post
 

diff --git a/openlibrary/macros/NotInLibrary.html b/openlibrary/macros/NotInLibrary.html
@@ -1,5 +1,14 @@
-$def with()
+$def with(link)
 
-<div class="cta-button-group">
-  <a class="cta-btn cta-btn--no-pointer">$_('Not in Library')</a>
-</div>
+$if link:
+  <div class="cta-button-group">
+    <a
+      class="cta-btn"
+      href="$link"
+      data-ol-link-track="CTAClick|NotInLibrary"
+    >$_('Not in Library')</a>
+  </div>
+$else:
+  <div class="cta-button-group">
+    <span class="cta-btn cta-btn--no-pointer">$_('Not in Library')</span>
+  </div>
diff --git a/static/css/components/buttonCta.less b/static/css/components/buttonCta.less
@@ -46,7 +46,7 @@ a.cta-btn {
   }
 
   &--no-pointer {
-    cursor: not-allowed;
+    cursor: default;
   }
 
   &--available, &--preview, &--primary {