Skip to content

Commit

Permalink
deps: update to use Node.js 18.16.0 with npm 9.5.1 to solve issue #1416
Browse files Browse the repository at this point in the history
… (#1423)
  • Loading branch information
shauke committed Apr 25, 2023
1 parent 20f75a2 commit 35adb46
Show file tree
Hide file tree
Showing 15 changed files with 24 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dead-code.yml
Expand Up @@ -7,7 +7,7 @@ on:
- cron: '0 0 * * 0'

env:
NODE_VERSION: 18.15.0
NODE_VERSION: 18.16.0

jobs:
TestBed:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/development.yml
Expand Up @@ -13,7 +13,7 @@ on:
- 'docs/**'

env:
NODE_VERSION: 18.15.0
NODE_VERSION: 18.16.0
ICM_BASE_URL: http://pwa-review.northeurope.cloudapp.azure.com:8081

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Expand Up @@ -8,7 +8,7 @@ on:
types: [opened, synchronize]

env:
NODE_VERSION: 18.15.0
NODE_VERSION: 18.16.0

jobs:
Docs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
Expand Up @@ -13,7 +13,7 @@ on:
- 'docs/**'

env:
NODE_VERSION: 18.15.0
NODE_VERSION: 18.16.0
NODE_OPTIONS: --max_old_space_size=8192
ICM_BASE_URL: http://pwa-review.northeurope.cloudapp.azure.com:8081

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/updates.yml
Expand Up @@ -10,7 +10,7 @@ on:
- cron: '0 0 * * *'

env:
NODE_VERSION: 18.15.0
NODE_VERSION: 18.16.0

jobs:
Updates:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
Expand Up @@ -9,7 +9,7 @@ on:
- 'docs/**'

env:
NODE_VERSION: 18.15.0
NODE_VERSION: 18.16.0
NODE_OPTIONS: --max_old_space_size=8192
JEST_MAX_WORKERS: 1
CI: false
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
@@ -1,5 +1,5 @@
# synchronize-marker:docker-cache-share:begin
FROM node:18.15.0-alpine as buildstep
FROM node:18.16.0-alpine as buildstep
ENV CI=true
WORKDIR /workspace
COPY package.json package-lock.json /workspace/
Expand Down Expand Up @@ -27,7 +27,7 @@ RUN npm run build:multi server
RUN node scripts/compile-docker-scripts
COPY dist/* /workspace/dist/

FROM node:18.15.0-alpine
FROM node:18.16.0-alpine
COPY --from=buildstep /workspace/dist /dist
RUN cd dist && npm install
ARG displayVersion=
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile_reports
@@ -1,7 +1,7 @@
# To build this report image, you will have to temporarily truncate the .dockerignore

# synchronize-marker:docker-cache-share:begin
FROM node:18.15.0-alpine as buildstep
FROM node:18.16.0-alpine as buildstep
ENV CI=true
WORKDIR /workspace
COPY package.json package-lock.json /workspace/
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/getting-started.md
Expand Up @@ -10,7 +10,7 @@ kb_sync_latest_only
## Quick Start

Before working with this project, download and install [Node.js](https://nodejs.org) with the included npm package manager.
Currently Node.js 18.15.0 LTS with the corresponding npm 9.5.0 is used for development.
Currently Node.js 18.16.0 LTS with the corresponding npm 9.5.1 is used for development.

After having cloned the project from the Git repository, open a command line in the project folder and run `npm install`.

Expand Down
4 changes: 4 additions & 0 deletions docs/guides/migrations.md
Expand Up @@ -7,6 +7,10 @@ kb_sync_latest_only

# Migrations

## 4.0 to 4.1

The Intershop PWA now uses Node.js 18.16.0 LTS with the corresponding npm version 9.5.1 to resolve an issue with Azure docker deployments (see #1416).

## 3.3 to 4.0

The Intershop PWA now uses Node.js 18.15.0 LTS with the corresponding npm version 9.5.0 and the `"lockfileVersion": 3,`.
Expand Down
8 changes: 4 additions & 4 deletions e2e/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion e2e/package.json
Expand Up @@ -22,6 +22,6 @@
},
"devDependencies": {
"@types/lodash": "4.14.191",
"@types/node": "^18.15.11"
"@types/node": "^18.16.0"
}
}
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -7,8 +7,8 @@
"intershop"
],
"engines": {
"node": "18.15.0",
"npm": "9.5.0"
"node": "18.16.0",
"npm": "9.5.1"
},
"private": true,
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion templates/Dockerfile_dev
@@ -1,4 +1,4 @@
FROM node:18.15.0-alpine as buildstep
FROM node:18.16.0-alpine as buildstep
ENV CI=true
COPY . /workspace/
WORKDIR /workspace
Expand Down

0 comments on commit 35adb46

Please sign in to comment.