-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/migrato 173 #49
base: develop
Are you sure you want to change the base?
Conversation
@@ -541,6 +541,11 @@ protected function createUserField($entity, $count = 1) | |||
*/ | |||
protected function createUserFieldEnum($module, $filter, $count = 1) | |||
{ | |||
if (is_callable($filter) === false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У тебя PhpStorm видимо настроен неправильно. Везде должны быть табы вместо пробелов. Поправь плз
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Посмотри где вызывается эта функция. Там везде строкой в $filter передается название метода. У меня есть сомнения, что с твоим условием код отработает. Скорее всего нужно будет доработать вызовы этого метода еще
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UP! форматирование
lib/tool/console/logger.php
Outdated
@@ -556,6 +556,10 @@ public function handle($error) | |||
} | |||
else | |||
{ | |||
$temp = fopen($_SERVER['DOCUMENT_ROOT'] . '/log/__lancy_backtrace.log', 'a+'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно убрать отладку
tools/backup.php
Outdated
@@ -57,9 +57,9 @@ function setValue($name, $value) | |||
if ($noUpload) { | |||
$fileMask = array_unique(array_merge($fileMask, ['/upload'])); | |||
} else { | |||
$fileMask = array_flip($fileMask); | |||
$fileMask = array_flip(is_array($fileMask) ? $fileMask : []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лучше заменить на $fileMask ?: []
@@ -116,6 +120,7 @@ public static function updateMessages($hlBlockId, $arFields) | |||
)); | |||
} | |||
} | |||
echo "\n\t4"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Что это?
@@ -541,6 +541,11 @@ protected function createUserField($entity, $count = 1) | |||
*/ | |||
protected function createUserFieldEnum($module, $filter, $count = 1) | |||
{ | |||
if (is_callable($filter) === false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UP! форматирование
lib/data/module/main/group.php
Outdated
@@ -58,7 +58,13 @@ protected function addSecurityPolicySettings(Record $record) | |||
{ | |||
$getElement = \CGroup::GetByID($record->getId()->getValue(), "N"); | |||
$groupElement = $getElement->Fetch(); | |||
$arSecurityPolicy = unserialize($groupElement['SECURITY_POLICY']); | |||
$arSecurityPolicy = $groupElement['SECURITY_POLICY'] ?: []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
пробелы -> табы
No description provided.