feature: add support for Codeium chat #485

etaldot · 2024-04-10T21:53:44Z

No description provided.

Tool/Sources/Preferences/Keys.swift

khou22 · 2024-04-11T00:30:06Z

Copilot for Xcode.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -27,6 +27,15 @@
        "version" : "1.0.2"
      }
    },
+    {
+      "identity" : "generative-ai-swift",


What do these changes do?

The Package.resolved file is updated because I mostly develop in another workspace. Maybe it's better to just uncheck the file for this pull request if no dependency is added?

Tool/Sources/CodeiumService/CodeiumLanguageServer.swift

intitni · 2024-04-11T01:57:33Z

Wow, I was also planning to do this in the next phase when the chat feature is upgraded, but pull requests are always welcomed.

Do you mind explaining how Codeium chat will be integrated in this pull request?

khou22 · 2024-04-11T02:13:05Z

Wow, I was also planning to do this in the next phase when the chat feature is upgraded, but pull requests are always welcomed.

Do you mind explaining how Codeium chat will be integrated in this pull request?

Kevin from the Codeium team here. We are going to be bringing Codeium Chat to Xcode! @etaldot is implementing this right now and will be opening PRs in the next week. How it works at a high level:

Language server has two process that we will enable: web socket server and chat web client bundle
The web client bundle will be served on a free port and will be embedded via iFrame or browser window. This will connect to the web socket server.
In future PRs, there will be links, inline buttons, etc. that will enable users to click a "Code Lens" above a function definition to explain a piece of code. This will send a request to the web socket server and the result will be streamed to any open chat clients.

Let me know if you have other questions! We're excited to be releasing this soon 🙂

etaldot

@intitni I left a question. Any help would be awesome. Looking forward to contribute to this!

etaldot · 2024-04-12T18:16:44Z

Tool/Sources/XPCShared/XPCServiceProtocol.swift

@@ -35,6 +35,10 @@ public protocol XPCServiceProtocol {
        editorContent: Data,
        withReply reply: @escaping (Data?, Error?) -> Void
    )
+    func openChat(


@intitni one question. I want to show this command only if codeium is setup to open chat. Additionally, I want to be able to call this directly. Right now it goes through the XPCService to get API keys etc, do you know of a better way

Please reuse the ChatWithSelectionCommand and handle it in the service target. This command is named Open Chat but the type name was unchanged back then.

If you want to call a command programmatically, please use XcodeInspector.shared.safe.latestActiveXcode?.triggerCopilotCommand(name: "command name").

Can you explain what do you mean by service target @intitni ?

I would suggest adding a picker in the chat settings to allow users to select what the open chat command will do. And handle it in func chatWithSelection(editor: EditorContent) in WindowBaseCommandHandler.swift.

It's just not recommended to add dynamic items to the Xcode menu because it can't be refreshed until Xcode is restarted.

I mean this.

intitni · 2024-04-13T04:33:19Z

Tool/Sources/XPCShared/XPCServiceProtocol.swift

@@ -35,6 +35,10 @@ public protocol XPCServiceProtocol {
        editorContent: Data,
        withReply reply: @escaping (Data?, Error?) -> Void
    )
+    func openChat(


Please reuse the ChatWithSelectionCommand and handle it in the service target. This command is named Open Chat but the type name was unchanged back then.

If you want to call a command programmatically, please use XcodeInspector.shared.safe.latestActiveXcode?.triggerCopilotCommand(name: "command name").

intitni · 2024-04-13T04:37:23Z

Tool/Sources/SuggestionProvider/SuggestionProvider.swift

@@ -47,6 +47,7 @@ public protocol SuggestionServiceProvider {
    func notifyChangeTextDocument(fileURL: URL, content: String) async throws
    func notifyCloseTextDocument(fileURL: URL) async throws
    func notifySaveTextDocument(fileURL: URL) async throws
+    func openChat() async throws


Please handle the openChat in a different place. SuggestionProvider is for suggestions only. If the code is too hard to reach, you can use NotificationCenter to post a notification.

The reason I added this as a separate command called open chat rather than chat with selection was to distinguish between chatting with ChatGPT vs Codeium Chat. Can you explain further how would this look like if I were to move this out @intitni

I would suggest adding a picker in the chat settings to allow users to select what the open chat command will do. And handle it in func chatWithSelection(editor: EditorContent) in WindowBaseCommandHandler.swift.

It's just not recommended to add dynamic items to the Xcode menu because it can't be refreshed until Xcode is restarted.

I also found that the openChat method is added to SuggestionWorkspacePlugin.swift, Please create a CodeiumWorkspacePlugin.swift and register it in Service.swift

Actually there is no API suitable for accessing the CodeiumService in another workspace plugin at the moment. Let's keep the changes in SuggestionProvider/WorkspacePlugin in this pr and only change the command.

@intitni just to be clear, you are suggesting continuing to use the suggestion service but only change the command to use ChatWithSelection with a toggle that allows users to either use github copilot or codeium as a chat method correct?

Correct.

either use github copilot or codeium as a chat method

Please use words like builtin instead of GitHub Copilot because we don't support GitHub Copilot chat at all.

Tool/Sources/CodeiumService/CodeiumService.swift

chore: initialize chat server if enabled

979b204

khou22 reviewed Apr 11, 2024

View reviewed changes

etaldot added 2 commits April 11, 2024 00:34

chore: always enabled chat

a0a9464

chore: add process ports endpoint

3e1a06d

etaldot commented Apr 12, 2024

View reviewed changes

fix: getting ports

d0a79c6

etaldot force-pushed the feat/add-support-for-codeium-chat branch from e8187c0 to d0a79c6 Compare April 13, 2024 05:23

etaldot marked this pull request as ready for review April 13, 2024 05:24

etaldot requested review from intitni and khou22 April 13, 2024 05:24

intitni requested changes Apr 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: add support for Codeium chat #485

feature: add support for Codeium chat #485

etaldot commented Apr 10, 2024

khou22 Apr 11, 2024

intitni Apr 11, 2024

intitni commented Apr 11, 2024

khou22 commented Apr 11, 2024

etaldot left a comment

etaldot Apr 12, 2024

intitni Apr 13, 2024

etaldot Apr 16, 2024 •

edited

intitni Apr 16, 2024 •

edited

intitni Apr 13, 2024

intitni Apr 13, 2024

etaldot Apr 16, 2024 •

edited

intitni Apr 16, 2024 •

edited

intitni Apr 16, 2024

intitni Apr 16, 2024 •

edited

etaldot Apr 16, 2024

intitni Apr 16, 2024

feature: add support for Codeium chat #485

Are you sure you want to change the base?

feature: add support for Codeium chat #485

Conversation

etaldot commented Apr 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

intitni commented Apr 11, 2024

khou22 commented Apr 11, 2024

etaldot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etaldot Apr 16, 2024 • edited

Choose a reason for hiding this comment

intitni Apr 16, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etaldot Apr 16, 2024 • edited

Choose a reason for hiding this comment

intitni Apr 16, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

intitni Apr 16, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etaldot Apr 16, 2024 •

edited

intitni Apr 16, 2024 •

edited

etaldot Apr 16, 2024 •

edited

intitni Apr 16, 2024 •

edited

intitni Apr 16, 2024 •

edited