Support passing composer instance to Translation component #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary for using the scope of the compilation parent component when placed inside a slot of a custom component.
kazupon
requested changes
Apr 13, 2021
| * @remarks | ||
| * An existing i18n Composer instance to use for translating | ||
| */ | ||
| i18n?: Composer |
There was a problem hiding this comment.
I think this issue is not only with the Translation component but also with the DatetimeFormat and NumberFormat components.
I hope that you could define it to BaseFormatProps interface and baseFormatProps prop.
https://github.com/intlify/vue-i18n-next/blob/master/packages/vue-i18n/src/components/base.ts
kazupon
approved these changes
Apr 14, 2021
|
Thank you for your contribution! |
|
@kazupon thank you for all the amazing work! Hontoni arigato gozaimasu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
<i18n-t>inside a slot of a custom component, it will try to use the scope of the parent component, but because of being inserted into a slot, its parent is now that custom component instead of the original parent component, where the template that used<i18n-t>was compiled. As a more concrete example:Parentcomponent defines an i18n scope, and a message with keyhello.Parentcomponent usesChildcomponent in its template.Childcomponent defines a slot namedcontentand a new i18n scope (without any messages).Parentcomponent uses<i18n-t keypath="hello">inside thecontentslot ofChildcomponent.<i18n-t>looks for the message with keyhellobut can't find it in its "parent" component because it's not longerParent, butChildinstead.The expected behavior would be for
<i18n-t>to look for the messages inParentcomponent instead, since that's where it was used in the first place.I've looked through the source code and can't find a way to somehow trace the parent lookup chain back to where the Translation component was used instead of where it lands through the slot.
The only way I found to make this work was to allow for passing an actual
i18ncomposer instance to the<i18n-t>component as a prop, so it can be directly used if provided, or fall back to the regular behavior otherwise. This way we can pass thei18ncomposer instance fromParentcomponent directly to<i18n-t>even if it's placed inside the slot of a custom component that creates its own i18n scope.Hopefully you find this useful and decide to merge it!