Merge pull request #1847 from intuit/slack-validation-bug

groups authors
intuit · Mar 3, 2021 · 23b8a56 · 23b8a56
2 parents 4216e64 + ebeb6de
commit 23b8a56
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/plugins/slack/__tests__/__snapshots__/slack.test.ts.snap b/plugins/slack/__tests__/__snapshots__/slack.test.ts.snap
@@ -170,7 +170,8 @@ Array [
     Object {
       "elements": Array [
         Object {
-          "text": "• Andrew Lisowski (<https://github.com/hipstersmoothie|@hipstersmoothie>)",
+          "text": "• Andrew Lisowski (<https://github.com/hipstersmoothie|@hipstersmoothie>)
+• Other",
           "type": "mrkdwn",
         },
       ],

diff --git a/plugins/slack/__tests__/slack.test.ts b/plugins/slack/__tests__/slack.test.ts
@@ -503,6 +503,7 @@ describe("convertToBlocks", () => {
           #### Authors: 1
           
           - Andrew Lisowski ([@hipstersmoothie](https://github.com/hipstersmoothie))
+          - Other
       `)
       )
     ).toMatchSnapshot();

diff --git a/plugins/slack/src/index.ts b/plugins/slack/src/index.ts
@@ -126,12 +126,15 @@ export function convertToBlocks(
     } else if (line.startsWith("*Authors:")) {
       currentMessage.push(createDividerBlock());
       currentMessage.push(createContextBlock(line));
+      const authorLines: string[] = [];
 
       for (const authorLine of lineIterator) {
         if (authorLine) {
-          currentMessage.push(createContextBlock(authorLine));
+          authorLines.push(authorLine);
         }
       }
+
+      currentMessage.push(createContextBlock(authorLines.join("\n")));
     } else if (line.match(CHANGELOG_LINE)) {
       const lines: string[] = [line];