Merge pull request #1758 from hborawski/conventional-labels

feat: conventional commit plugin will label an unlabeled PR
intuit · Feb 3, 2021 · a66eb87 · a66eb87
2 parents 1d01fd3 + a9e87c0
commit a66eb87
Show file tree

Hide file tree

Showing 5 changed files with 538 additions and 287 deletions.
diff --git a/packages/core/src/auto.ts b/packages/core/src/auto.ts
@@ -2230,7 +2230,8 @@ export { IPlugin } from "./utils/load-plugins";
 export { ICommitAuthor, IExtendedCommit } from "./log-parse";
 
 export { default as Auto } from "./auto";
-export { default as SEMVER, VersionLabel } from "./semver";
+export { default as SEMVER } from "./semver";
+export * from "./semver";
 export { default as execPromise } from "./utils/exec-promise";
 export {
   default as getLernaPackages,

diff --git a/packages/core/src/semver.ts b/packages/core/src/semver.ts
@@ -164,7 +164,7 @@ export function getHigherSemverTag(left: SEMVER, right: SEMVER): SEMVER {
 }
 
 /** Get the semver bump for a release type */
-const getBump = (releaseType?: ReleaseType) =>
+export const getReleaseType = (releaseType?: ReleaseType) =>
   releaseType === "none" || releaseType === "skip"
     ? SEMVER.noVersion
     : releaseType === "release"
@@ -202,7 +202,7 @@ export function calculateSemVerBump(
     // 2. It has labels but none of them are auto labels
     if (
       index === 0 &&
-      (pr.length === 0 || !pr.find((label) => getLabelEntry(label)))
+      (pr.length === 0 || !pr.some((label) => Boolean(getLabelEntry(label))))
     ) {
       releaseTypes.add(defaultReleaseType);
     }
@@ -238,6 +238,6 @@ export function calculateSemVerBump(
   }
 
   return [...releaseTypes]
-    .map(getBump)
-    .reduce(getHigherSemverTag, getBump(defaultReleaseType));
+    .map(getReleaseType)
+    .reduce(getHigherSemverTag, getReleaseType(defaultReleaseType));
 }