New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label creation adds unwanted default labels #1955
Comments
I was just about to file the same issue. The docs are unclear about overriding default labels. Is there a way to say that I want only those labels defined in the config and no default ones? |
There is an |
@hipstersmoothie when looking at https://intuit.github.io/auto/docs/generated/create-labels I don't see anything of that nature. Where is the docs pertaining to this option? |
@hipstersmoothie So looking at those docs, I guess I'm unclear about the functionality of that option. I would assume that if I add that to every one of my labels in my config, it would just overwrite the |
I agree with @reintroducing. I knew about |
@reintroducing I like that option a lot! Default can be only create specified labels. New flag to include the others and use the overwrite logic. This would be a breaking change to behavior though. What about the opposite |
@hipstersmoothie yes, sorry my explanation wasn't clear, i was suggesting the same thing you are but in reverse and it would be true by default, lol, to avoid a breaking change. yours is actually cleaner and aligns better with how all other options are done. I'm all for it! |
I might not have to to get to this until the weekend. If you submit a PR I'll review and merge prompts |
I made an attempt to fix it: #1966, but in a bit different way. See the explanation there. |
🚀 Issue was released in |
@laughedelic @hipstersmoothie @adierkens I just tried the upgrade to this and am seeing the following issue in CI where we create canaries automatically on a new PR: It's worth noting that the actual config is in a packages/auto/config.json file and is extended at the root of our repo using the following:
This was, however, working perfectly fine prior to updating to the latest version. Here is the full config.json file:
|
Is it possible that the new option needs to be added to the validator and its as simple as that? https://github.com/intuit/auto/blob/main/packages/core/src/types.ts#L54 |
This makes sense! I didn't know about it. |
@reintroducing I added it here: #1971. But I don't know if it should be added anywhere else. |
Describe the bug
When I run
npx auto create-labels
and have a given label configuration defined in my package.json, I would expect that only those labels get created, NOT the additional default labels defined by auto. This used to be the case but somewhere along the line stopped working correctly.To Reproduce
Using the following configuration:
This is the output:
Expected behavior
Only the labels outlined in the above config would be created. Anything after the
upgrade
label in the above output list is unwanted and should not be created.Screenshots
Environment information:
Additional context
The text was updated successfully, but these errors were encountered: